Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add client lib predict and train interfaces #11

Merged

Conversation

weicongs-amazon
Copy link
Contributor

@weicongs-amazon weicongs-amazon commented Apr 20, 2021

Signed-off-by: weicongs-amazon weicongs@amazon.com

Description

[Describe what this change achieves]

  • predict inteface
  • train interface

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

@zhanghg08 zhanghg08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor comments.

Copy link

@zhanghg08 zhanghg08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks for the updates.

@weicongs-amazon weicongs-amazon merged commit f239221 into opensearch-project:develop Apr 21, 2021
@weicongs-amazon weicongs-amazon deleted the client-lib-v2 branch April 21, 2021 18:17
jackiehanyang pushed a commit that referenced this pull request Nov 16, 2021
* add client lib predict and train interfaces

* Add exception check for UT cases

* fix exception check for UT cases in train method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants