Add gem's public key to repo for cert verification #44
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
force-pushed
the
add-public-key
branch
2 times, most recently
from
62c897a to
cd2d781
Compare
jmazanec15
reviewed
Aug 3, 2021
There was a problem hiding this comment.
@VijayanB Could you describe how the certificate was generated?
@jmazanec15 I updated the commit message but forgot to update PR description. Will update it now. |
jmazanec15
reviewed
Aug 3, 2021
If we don't add cert and install with HighSecurity it will fail. I tested this manually and works While in our case |
jmazanec15
approved these changes
Aug 3, 2021
VijayanB
force-pushed
the
add-public-key
branch
from
c432105 to
a6daf0f
Compare
This gem is cryptographically signed. To be sure the gem you install hasn’t been tampered with: Add certs/opensearch-rubygems.pem (if you haven’t already) as a trusted certificate gem cert --add <(curl -Ls certs/opensearch-rubygems.pem) gem install logstash-output-openserach -P HighSecurity The HighSecurity trust profile will verify signed gems, and allow only if all the dependencies are signed. This is created by following https://guides.rubygems.org/security/#building-gems Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
add-public-key
branch
from
a6daf0f to
db1f8d2
Compare
This was referenced Aug 5, 2021
Closed
Closed
VijayanB
added
the
Infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vijayan Balasubramanian balasvij@amazon.com
Description
This gem is cryptographically signed. To be sure the gem you install hasn’t been tampered with:
Add certs/opensearch-rubygems.pem (if you haven’t already) as a trusted certificate
The HighSecurity trust profile will verify signed gems, and allow only if all the dependencies are signed.
This is created by following https://guides.rubygems.org/security/#building-gems
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.