Adding filter type to filtering release configs #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
added
Infrastructure
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #792 +/- ##
=========================================
Coverage 85.14% 85.14%
Complexity 1079 1079
=========================================
Files 151 151
Lines 4370 4370
Branches 390 390
=========================================
Hits 3721 3721
Misses 472 472
Partials 177 177 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
navneet1v
previously approved these changes
Mar 7, 2023
|
@martin-gaievski can you fix the BWC test also which are failing. We need to now test upgrade from 2.7 to 3. |
VijayanB
previously approved these changes
Mar 7, 2023
@VijayanB will do a separate PR for BWC and 2.7, I'll rebase once that change is merged. |
|
Created PR #793 for bwc upgrade |
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
dismissed stale reviews from VijayanB and navneet1v
via
c65921a
martin-gaievski
force-pushed
the
add-filter-type-to-release-test-configs
branch
from
9345dbb to
c65921a
Compare
VijayanB
approved these changes
Mar 13, 2023
naveentatikonda
approved these changes
Mar 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 13, 2023
Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit e4cf3d4)
martin-gaievski
added a commit
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current release configs for filtering do not have filter type, this means they we're using default value SCRIPT that is for score scripting with exact k-NN search (docs on filtering test step). This is a gap in initial implementation, intended filter type is FILTER, it uses filtering logic based on Lucene implementation.
Issues Resolved
Identified during k-NN 2.6 release
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.