Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Disable Code Coverage for Windows and Mac Platforms #604

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d3f8959 from #603

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit d3f8959)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team October 29, 2022 01:50
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2022

Codecov Report

Merging #604 (d3f8959) into 2.x (0eece60) will decrease coverage by 0.03%.
The diff coverage is 85.67%.

❗ Current head d3f8959 differs from pull request most recent head 84c492f. Consider uploading reports for the commit 84c492f to get more accurate results

@@             Coverage Diff              @@
##                2.x     #604      +/-   ##
============================================
- Coverage     84.51%   84.47%   -0.04%     
+ Complexity     1054     1050       -4     
============================================
  Files           149      149              
  Lines          4301     4291      -10     
  Branches        382      379       -3     
============================================
- Hits           3635     3625      -10     
  Misses          489      489              
  Partials        177      177              
Impacted Files Coverage Δ
...n/java/org/opensearch/knn/common/KNNConstants.java 93.33% <ø> (ø)
.../main/java/org/opensearch/knn/index/IndexUtil.java 55.73% <ø> (ø)
...va/org/opensearch/knn/index/KNNCircuitBreaker.java 60.00% <0.00%> (ø)
.../main/java/org/opensearch/knn/index/KNNMethod.java 100.00% <ø> (ø)
...ava/org/opensearch/knn/index/KNNMethodContext.java 92.50% <ø> (ø)
...java/org/opensearch/knn/index/MethodComponent.java 88.88% <ø> (ø)
...g/opensearch/knn/index/MethodComponentContext.java 91.13% <ø> (ø)
...earch/knn/index/memory/NativeMemoryAllocation.java 82.92% <ø> (ø)
.../java/org/opensearch/knn/index/query/KNNQuery.java 83.33% <ø> (ø)
...org/opensearch/knn/index/query/KNNQueryResult.java 100.00% <ø> (ø)
... and 84 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@naveentatikonda naveentatikonda merged commit 847b074 into 2.x Oct 31, 2022
@github-actions github-actions bot deleted the backport/backport-603-to-2.x branch October 31, 2022 18:16
@heemin32 heemin32 added 2.4.0 v2.4.0 'Issues and PRs related to version v2.4.0' and removed 2.4.0 labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants