Concurrency optimization for graph native loading update #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gankris96
force-pushed
the
concurrent-graph-load-2.x
branch
from
28b0ef3 to
c1c693f
Compare
Signed-off-by: Ganesh Ramadurai <gramadur@icloud.com>
Gankris96
force-pushed
the
concurrent-graph-load-2.x
branch
from
c1c693f to
44c49b9
Compare
Gankris96
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas and
0ctopus13prime
as code owners
kotwanikunal
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Folks - can we get some reviews here?
@navneet1v / @shatejas / @jmazanec15
|
I need some help to add the backport-main tag to this PR |
navneet1v
approved these changes
Jan 27, 2025
shatejas
approved these changes
Jan 27, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
Signed-off-by: Ganesh Ramadurai <gramadur@icloud.com> (cherry picked from commit 7e4a2bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2265
Refactors the graph load into a 2 step approach detailed here - #2265 (comment)
This will help to move out the opening of indexInput file outside of the synchronized block so that the graphfile can be downloaded in parallel even if the graph load and createIndexAllocation are inside synchronized block.
Related Issues
Resolves #2265
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.