Add WithFieldName implementation to KNNQueryBuilder #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Wu <wumr@amazon.com>
markwu-sde
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas and
0ctopus13prime
as code owners
Signed-off-by: Mark Wu <wumr@amazon.com>
jmazanec15
approved these changes
Jan 16, 2025
dzane17
approved these changes
Jan 16, 2025
kotwanikunal
approved these changes
Jan 16, 2025
naveentatikonda
approved these changes
Jan 16, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Add WithFieldName implementation to KNNQueryBuilder Signed-off-by: Mark Wu <wumr@amazon.com> * Update CHANGELOG.md Signed-off-by: Mark Wu <wumr@amazon.com> --------- Signed-off-by: Mark Wu <wumr@amazon.com> (cherry picked from commit 7e817f2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add WithFieldName implementation to KNNQueryBuilder as an extension of PR 15705.
Related Issues
Resolves #2385
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.