Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license and attributions for faiss addition #187

Merged
merged 2 commits into from
Nov 7, 2021

Conversation

jmazanec15
Copy link
Member

Description

Add faiss to attributions and add openblas and faiss to third party (BSD 3 and MIT, respectively).

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding the contributors

@codecov-commenter
Copy link

Codecov Report

Merging #187 (1077e36) into main (3fdae61) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #187   +/-   ##
=========================================
  Coverage     82.78%   82.78%           
  Complexity      826      826           
=========================================
  Files           120      120           
  Lines          3631     3631           
  Branches        342      342           
=========================================
  Hits           3006     3006           
  Misses          468      468           
  Partials        157      157           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fdae61...1077e36. Read the comment docs.

@jmazanec15 jmazanec15 merged commit a7174b1 into opensearch-project:main Nov 7, 2021
@naveentatikonda naveentatikonda added the Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Nov 12, 2021
martin-gaievski pushed a commit to martin-gaievski/k-NN that referenced this pull request Mar 7, 2022
martin-gaievski pushed a commit to martin-gaievski/k-NN that referenced this pull request Mar 7, 2022
…t#187)

Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski pushed a commit to martin-gaievski/k-NN that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants