Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the arithmetic to find the number of vectors to stream from java to jni layer. #1804

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fixing the arithmetic to find the number of vectors to stream from java to jni layer. #1804

merged 1 commit into from
Jul 9, 2024

Conversation

navneet1v
Copy link
Collaborator

Description

Fixing the arithmetic to find the number of vectors to stream from java to jni layer.

Issues Resolved

NA

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@navneet1v navneet1v added Bug Fixes Changes to a system or product designed to handle a programming bug/glitch and removed skip-changelog labels Jul 9, 2024
@navneet1v
Fixing the arithmetic to find the number of vectors to stream from ja…
ac56da8 
…va to jni layer

Signed-off-by: Navneet Verma <navneev@amazon.com>
ryanbogan
ryanbogan approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@ryanbogan ryanbogan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise LGTM!

src/main/java/org/opensearch/knn/index/codec/util/KNNCodecUtil.java Show resolved Hide resolved
@navneet1v
Copy link
Collaborator Author

Thanks @jmazanec15 and @ryanbogan I will merge this PR once GH actions are completed

@navneet1v navneet1v merged commit 5a62f46 into opensearch-project:main Jul 9, 2024
51 of 53 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 9, 2024
@navneet1v @github-actions
Fixing the arithmetic to find the number of vectors to stream from ja…
a69dbfb 
…va to jni layer (#1804)

Signed-off-by: Navneet Verma <navneev@amazon.com>
(cherry picked from commit 5a62f46)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 9, 2024
Merged
navneet1v added a commit that referenced this pull request Jul 9, 2024
@opensearch-trigger-bot @navneet1v
Fixing the arithmetic to find the number of vectors to stream from ja…
c47fba1 
…va to jni layer (#1804) (#1805)

Signed-off-by: Navneet Verma <navneev@amazon.com>
(cherry picked from commit 5a62f46)

Co-authored-by: Navneet Verma <navneev@amazon.com>
heemin32 added a commit to heemin32/k-NN that referenced this pull request Jul 25, 2024
@heemin32
Apply opensearch-project#1804
2b738c9 
Signed-off-by: Heemin Kim <heemin@amazon.com>
@heemin32 heemin32 mentioned this pull request Jul 25, 2024
Merged
5 tasks
heemin32 added a commit to heemin32/k-NN that referenced this pull request Jul 25, 2024
@heemin32
Apply opensearch-project#1804
0e508a0 
Signed-off-by: Heemin Kim <heemin@amazon.com>
@heemin32 heemin32 mentioned this pull request Jul 25, 2024
Merged
5 tasks
heemin32 added a commit to heemin32/k-NN that referenced this pull request Jul 25, 2024
@heemin32
Apply opensearch-project#1804
65d484d 
Signed-off-by: Heemin Kim <heemin@amazon.com>
heemin32 added a commit to heemin32/k-NN that referenced this pull request Jul 25, 2024
@heemin32
Apply opensearch-project#1804
fb84fb9 
Signed-off-by: Heemin Kim <heemin@amazon.com>
heemin32 added a commit that referenced this pull request Jul 25, 2024
@heemin32
Apply #1804 (#1880)
c8ec49f 
Signed-off-by: Heemin Kim <heemin@amazon.com>
heemin32 added a commit that referenced this pull request Jul 25, 2024
@heemin32
Apply #1804 (#1882)
161a60a 
Signed-off-by: Heemin Kim <heemin@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 25, 2024
@heemin32 @github-actions
Apply #1804 (#1882)
a7eb924 
Signed-off-by: Heemin Kim <heemin@amazon.com>
(cherry picked from commit 161a60a)
heemin32 added a commit that referenced this pull request Jul 25, 2024
@opensearch-trigger-bot @heemin32
Apply #1804 (#1882) (#1886)
59bb71a 
Signed-off-by: Heemin Kim <heemin@amazon.com>
(cherry picked from commit 161a60a)

Co-authored-by: Heemin Kim <heemin@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanbogan ryanbogan ryanbogan approved these changes

@jmazanec15 jmazanec15 jmazanec15 approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

@luyuncheng luyuncheng Awaiting requested review from luyuncheng luyuncheng is a code owner

Assignees
No one assigned
Labels
backport 2.x Bug Fixes Changes to a system or product designed to handle a programming bug/glitch
Projects
Vector Search RoadMap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@navneet1v @ryanbogan @jmazanec15