-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation to check max int limit in train API #159
Conversation
Signed-off-by: John Mazanec <jmazane@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
=========================================
Coverage 82.82% 82.82%
Complexity 801 801
=========================================
Files 117 117
Lines 3580 3580
Branches 339 339
=========================================
Hits 2965 2965
Misses 461 461
Partials 154 154
Continue to review full report at Codecov.
|
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com> Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec jmazane@amazon.com
Description
This PR checks to see if the int parameters in the training API are within integer bounds. If not, it will throw an illegal argument exception which will get propagated back to the user as a 400 error.
For validation, we use the NumberFieldMappers INTEGER type's parser. Code can be found here.
Validation:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.