SQFP16 Range Validation for Faiss IVF Models #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveentatikonda
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda
force-pushed
the
range_validation_fp16_ivf
branch
from
ff6665d to
e0cb80d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/faiss_sqfp16 #1557 +/- ##
==========================================================
+ Coverage 84.36% 84.43% +0.06%
- Complexity 1342 1345 +3
==========================================================
Files 171 171
Lines 5507 5511 +4
Branches 545 545
==========================================================
+ Hits 4646 4653 +7
+ Misses 626 624 -2
+ Partials 235 234 -1 ☔ View full report in Codecov by Sentry. |
jmazanec15
reviewed
Mar 18, 2024
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
jmazanec15
approved these changes
Mar 18, 2024
naveentatikonda
merged commit 14c371b
into
opensearch-project:feature/faiss_sqfp16
52 checks passed
naveentatikonda
added a commit
that referenced
this pull request
Mar 18, 2024
* SQFP16 Range Validation for Faiss IVF Models Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Address Review Comments Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
5 tasks
naveentatikonda
added a commit
that referenced
this pull request
Mar 18, 2024
* Add Range Validation for SQFP16 (#1493) * Add Range Validation for SQFP16 Vector Data Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Add index setting to clip vector data to FP16 range Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Add CHANGELOG Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Add an encoder parameter to clip fp16 range Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Address Review Comments Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Add BWC Tests Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * SQFP16 Range Validation for Faiss IVF Models (#1557) * SQFP16 Range Validation for Faiss IVF Models Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Address Review Comments Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Rebase Changes Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
* Add Range Validation for SQFP16 (#1493) * Add Range Validation for SQFP16 Vector Data Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Add index setting to clip vector data to FP16 range Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Add CHANGELOG Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Add an encoder parameter to clip fp16 range Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Address Review Comments Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Add BWC Tests Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * SQFP16 Range Validation for Faiss IVF Models (#1557) * SQFP16 Range Validation for Faiss IVF Models Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Address Review Comments Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Rebase Changes Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> (cherry picked from commit d63ce27)
naveentatikonda
added a commit
that referenced
this pull request
Mar 18, 2024
* Faiss SQFP16 Range Validation and Clipping (#1562) * Add Range Validation for SQFP16 (#1493) * Add Range Validation for SQFP16 Vector Data Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Add index setting to clip vector data to FP16 range Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Add CHANGELOG Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Add an encoder parameter to clip fp16 range Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Address Review Comments Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Add BWC Tests Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * SQFP16 Range Validation for Faiss IVF Models (#1557) * SQFP16 Range Validation for Faiss IVF Models Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Address Review Comments Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Rebase Changes Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> (cherry picked from commit d63ce27) * Fix EntityUtils package Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> Co-authored-by: Naveen Tatikonda <navtat@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Faiss SQfp16 Range Validation for Faiss IVF Models and to clip out of range values to fp16 range when the
clipencoder parameter is set totrue.Issues Resolved
#1138
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.