Update branch pattern #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
force-pushed
the
update-pattern
branch
from
53c2ffc
to
08aab50
Compare
Since feature branch will have "feature/" as prefix, updated branch pattern to include feature branch as well. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
update-pattern
branch
from
08aab50
to
cb2a41f
Compare
Codecov Report
@@ Coverage Diff @@
## main #123 +/- ##
============================================
- Coverage 83.14% 82.48% -0.66%
+ Complexity 480 474 -6
============================================
Files 69 69
Lines 1821 1821
Branches 178 178
============================================
- Hits 1514 1502 -12
- Misses 247 257 +10
- Partials 60 62 +2
Continue to review full report at Codecov.
|
vamshin
reviewed
Oct 6, 2021
| pull_request: | ||
| branches: | ||
| - "*" | ||
| schedule: | ||
| - cron: '0 */12 * * *' |
There was a problem hiding this comment.
I added this before 1.0 release and it is not relevant anymore since we are building against snapshot.
vamshin
reviewed
Oct 6, 2021
| @@ -3,11 +3,11 @@ on: | |||
| push: | |||
| branches: | |||
| - "*" | |||
There was a problem hiding this comment.
question: Does '*' does not take care of all the branch names?
There was a problem hiding this comment.
Unfortunately no. it will not match "/".
naveentatikonda
added
the
Infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vijayan Balasubramanian balasvij@amazon.com
Description
Since feature branch will have "feature/" as prefix,
updated branch pattern to include all branch that contains
"/".
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.