Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto increment version after release. #115

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

dblock
Copy link
Member

@dblock dblock commented Jan 11, 2022

Signed-off-by: dblock dblock@amazon.com

Description

Adds a workflow that increments the version in build.gradle whenever a new X.Y.Z.0 tag is pushed.

The idea is that every repo can have its own version of this to increment a patch release. When, for example, 1.2.3 is released and tagged, every repo would automatically get a PR to increment the version to the next development iteration on the release branch (e.g. 1.2). These jobs would fail until a -SNAPSHOT build of OpenSearch is available, which is already automated. One would come to this PR, re-run the CI, and merge on green.

This is identical to opensearch-project/common-utils#106.

Notes

The version is removed from ci.yml because the workflow is not allowed to push a change to workflows without a different access token. You get this error.

To https://github.com/dblock/common-utils
   ! [remote rejected] HEAD -> create-pull-request/patch (refusing to allow a GitHub App to create or update workflow `.github/workflows/ci.yml` without `workflows` permission)
  error: failed to push some refs to 'https://github.com/dblock/common-utils'

We can just use the default in build.gradle.

Issues Resolved

Part of opensearch-project/opensearch-build#1375.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock requested review from lezzago, saratvemulapalli and a team January 11, 2022 18:37
@dblock dblock merged commit ff53a31 into opensearch-project:main Jan 13, 2022
@dblock dblock deleted the auto-increment-version branch January 13, 2022 17:27
amitgalitz pushed a commit to amitgalitz/job-scheduler that referenced this pull request Feb 2, 2022
wuychn pushed a commit to ochprince/job-scheduler that referenced this pull request Mar 16, 2023
Signed-off-by: dblock <dblock@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants