Skip to content

Conversation

@bowenlan-amzn
Copy link
Member

Issue #, if available:

Description of changes:
Make sure we have the function of running tests against a security enabled cluster.

Commands:

./gradlew run -Dsecurity=true // bring up a security enabled cluster with ISM installed

./gradlew integTest -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername=elasticsearch -Dhttps=true  // running test against remote security enabled domain

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
@dbbaughe
Copy link
Contributor

dbbaughe commented Jul 1, 2021

  1. This seems to not allow us to run security enabled integ tests in our own repo in our own workflow which is something we want. Create a new issue to get that working if it's broken.

  2. Check if this allows the infra security enabled tests to run successfully

@codecov-commenter
Copy link

Codecov Report

Merging #93 (3fe69e1) into main (d415a03) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #93      +/-   ##
============================================
- Coverage     77.95%   77.88%   -0.07%     
- Complexity     1870     1876       +6     
============================================
  Files           255      255              
  Lines         10378    10378              
  Branches       1534     1534              
============================================
- Hits           8090     8083       -7     
+ Misses         1464     1461       -3     
- Partials        824      834      +10     
Impacted Files Coverage Δ
...statemanagement/model/destination/CustomWebhook.kt 65.21% <0.00%> (-28.99%) ⬇️
...anagement/indexstatemanagement/model/Transition.kt 64.61% <0.00%> (-3.08%) ⬇️
...ndexstatemanagement/IndexStateManagementHistory.kt 80.32% <0.00%> (-1.64%) ⬇️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 73.72% <0.00%> (-0.43%) ⬇️
...agement/indexstatemanagement/ManagedIndexRunner.kt 54.82% <0.00%> (+0.50%) ⬆️
...ent/indexstatemanagement/util/ManagedIndexUtils.kt 78.69% <0.00%> (+1.30%) ⬆️
...dexmanagement/transform/model/TransformMetadata.kt 90.36% <0.00%> (+3.61%) ⬆️
...ent/rollup/action/explain/ExplainRollupResponse.kt 85.00% <0.00%> (+10.00%) ⬆️
...ansform/action/explain/ExplainTransformResponse.kt 77.77% <0.00%> (+11.11%) ⬆️
...nt/indexstatemanagement/model/destination/Chime.kt 54.54% <0.00%> (+13.63%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d415a03...3fe69e1. Read the comment docs.

@bowenlan-amzn bowenlan-amzn merged commit c26dbf9 into opensearch-project:main Jul 1, 2021
@bowenlan-amzn bowenlan-amzn deleted the securitytest branch July 1, 2021 17:11
@bowenlan-amzn bowenlan-amzn mentioned this pull request Jul 1, 2021
2 tasks
thalurur pushed a commit to thalurur/open-index-management that referenced this pull request Oct 22, 2021
)

* Fixed Transforms geo_point bug and boolean render
* Set default DefineTransforms table render behavior to JSON.stringify
* Updated DefineTransforms null cell value check

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants