Fix NPE for transform aggregations #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hailong-am
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
gaobinlong,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
xluo-aws
as code owners
|
may need to merge after #825 |
zhichao-aws
reviewed
Jun 27, 2023
src/main/kotlin/org/opensearch/indexmanagement/transform/model/Transform.kt
Outdated
Show resolved
Hide resolved
|
caused by opensearch-project/OpenSearch#8206 |
1 task
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #830 +/- ##
============================================
+ Coverage 75.53% 75.57% +0.03%
- Complexity 2831 2843 +12
============================================
Files 364 364
Lines 16176 16176
Branches 2324 2325 +1
============================================
+ Hits 12219 12225 +6
+ Misses 2619 2606 -13
- Partials 1338 1345 +7
|
gaobinlong
approved these changes
Jun 29, 2023
xluo-aws
approved these changes
Jun 29, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 9fbc083)
Hailong-am
added a commit
to Hailong-am/index-management
that referenced
this pull request
Jun 30, 2023
Signed-off-by: Hailong Cui <ihailong@amazon.com>
1 task
bowenlan-amzn
pushed a commit
that referenced
this pull request
Jul 2, 2023
* Metadata members from ImmutableOpenMap to j.u.Map Signed-off-by: Hailong Cui <ihailong@amazon.com> * add field remoteStoreIndexShallowCopy in SM TestUtils (#825) Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix NPE for transform aggregations (#830) Signed-off-by: Hailong Cui <ihailong@amazon.com> * Fix detekt Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: zhichao-aws <zhichaog@amazon.com>
ronnaksaxena
pushed a commit
to ronnaksaxena/index-management
that referenced
this pull request
Jul 19, 2023
* Metadata members from ImmutableOpenMap to j.u.Map Signed-off-by: Hailong Cui <ihailong@amazon.com> * add field remoteStoreIndexShallowCopy in SM TestUtils (opensearch-project#825) Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix NPE for transform aggregations (opensearch-project#830) Signed-off-by: Hailong Cui <ihailong@amazon.com> * Fix detekt Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: Ronnak Saxena <ronsax@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#829
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.