Skip to content

Conversation

@bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Jun 3, 2021

Signed-off-by: bowenlan-amzn bowenlan23@gmail.com

Issue #, if available:
#68

Description of changes:
This issue starts on ES 7.10/OpenSearch 1.0, LocalNodeMasterListener will use the same thread for cluster state update which is a single thread pool. So our ism history rollover task will block this thread. This will happen when there is a master re-election and rollover satisfy the contition.

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
1. IntegTestCase cannot connect to remote cluster
2. cluster health check failed after test, happen after one core change
opensearch-project/OpenSearch@733d9c6
@codecov-commenter
Copy link

Codecov Report

Merging #70 (25d275b) into main (6bc118c) will decrease coverage by 0.79%.
The diff coverage is 70.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #70      +/-   ##
============================================
- Coverage     77.83%   77.03%   -0.80%     
+ Complexity     1862     1828      -34     
============================================
  Files           255      255              
  Lines          9988    10261     +273     
  Branches       1515     1517       +2     
============================================
+ Hits           7774     7905     +131     
- Misses         1393     1546     +153     
+ Partials        821      810      -11     
Impacted Files Coverage Δ
...pensearch/indexmanagement/IndexManagementRunner.kt 55.55% <ø> (ø)
...management/common/model/dimension/DateHistogram.kt 75.60% <ø> (ø)
...ndexmanagement/common/model/dimension/Dimension.kt 85.71% <ø> (ø)
...ndexmanagement/common/model/dimension/Histogram.kt 65.07% <ø> (ø)
...ch/indexmanagement/common/model/dimension/Terms.kt 77.04% <ø> (ø)
...management/indexstatemanagement/MetadataService.kt 27.95% <0.00%> (-34.41%) ⬇️
...nt/indexstatemanagement/action/AllocationAction.kt 83.33% <ø> (ø)
...agement/indexstatemanagement/action/CloseAction.kt 100.00% <ø> (ø)
...gement/indexstatemanagement/action/DeleteAction.kt 0.00% <ø> (ø)
...nt/indexstatemanagement/action/ForceMergeAction.kt 75.00% <ø> (ø)
... and 192 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b39ea...25d275b. Read the comment docs.

@bowenlan-amzn bowenlan-amzn merged commit ad4a54d into opensearch-project:main Jun 8, 2021
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
* fix 7.10 rollover blocking thread issue

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* exclude metadata regression test

1. IntegTestCase cannot connect to remote cluster
2. cluster health check failed after test, happen after one core change
opensearch-project/OpenSearch@733d9c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants