Skip to content

[Backport 1.x] removed recursion from Explain Action to avoid stackoverflow in some … #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2022
Merged

[Backport 1.x] removed recursion from Explain Action to avoid stackoverflow in some … #420

merged 1 commit into from
Jul 21, 2022

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport 76de976 from #419

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team July 20, 2022 17:34
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022 •
edited
Loading

Codecov Report

Merging #420 (1cd61ed) into 1.x (e9075dd) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                1.x     #420      +/-   ##
============================================
- Coverage     75.68%   75.39%   -0.29%     
+ Complexity     2014     2000      -14     
============================================
  Files           253      253              
  Lines         11490    11475      -15     
  Branches       1819     1816       -3     
============================================
- Hits           8696     8652      -44     
- Misses         1763     1811      +48     
+ Partials       1031     1012      -19
Impacted Files Coverage Δ
...transport/action/explain/TransportExplainAction.kt 71.12% <0.00%> (+5.28%) ⬆️
...xmanagement/rollup/actionfilter/FieldCapsFilter.kt 45.88% <0.00%> (-28.24%) ⬇️
...nt/indexstatemanagement/model/destination/Slack.kt 40.90% <0.00%> (-13.64%) ⬇️
...indexmanagement/rollup/model/RollupFieldMapping.kt 75.00% <0.00%> (-8.34%) ⬇️
.../rollup/action/start/TransportStartRollupAction.kt 67.44% <0.00%> (-2.33%) ⬇️
.../opensearch/indexmanagement/rollup/model/Rollup.kt 84.90% <0.00%> (ø)
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 67.16% <0.00%> (+1.19%) ⬆️
...management/indexstatemanagement/MetadataService.kt 63.28% <0.00%> (+2.34%) ⬆️
...arch/indexmanagement/rollup/RollupSearchService.kt 64.81% <0.00%> (+5.55%) ⬆️

@petardz @downsrob
Removed recursion from Explain Action to avoid stackoverflow in some …
1cd61ed 
…situations (#419)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)
@downsrob downsrob force-pushed the backport/backport-419-to-1.x branch from 76f912d to 1cd61ed Compare July 20, 2022 18:16
@bowenlan-amzn bowenlan-amzn merged commit 4df1b41 into 1.x Jul 21, 2022
opensearch-trigger-bot bot added a commit that referenced this pull request Jul 21, 2022
@opensearch-trigger-bot @petardz @github-actions
Removed recursion from Explain Action to avoid stackoverflow in some …
b02148a 
…situations (#419) (#420)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 4df1b41)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 21, 2022
Merged
@github-actions github-actions bot deleted the backport/backport-419-to-1.x branch July 21, 2022 17:40
downsrob pushed a commit that referenced this pull request Jul 27, 2022
@opensearch-trigger-bot
Removed recursion from Explain Action to avoid stackoverflow in some …
f8113ce 
…situations (#419) (#420) (#424)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 4df1b41)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bowenlan-amzn bowenlan-amzn bowenlan-amzn approved these changes

+1 more reviewer

@downsrob downsrob downsrob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 1.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@codecov-commenter @bowenlan-amzn @downsrob @petardz