Skip to content

Conversation

@thalurur
Copy link
Contributor

@thalurur thalurur commented Apr 20, 2021

Issue #, if available:

Description of changes:
Support source indices which have custom specified _type in rollup jobs

CheckList:
[ X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ravi Thaluru <ravi1092@gmail.com>
Signed-off-by: Ravi Thaluru <ravi1092@gmail.com>
@thalurur thalurur requested a review from bowenlan-amzn June 10, 2021 16:57
@codecov-commenter
Copy link

Codecov Report

Merging #4 (7cd61b7) into main (1e70b25) will decrease coverage by 0.26%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main       #4      +/-   ##
============================================
- Coverage     78.09%   77.82%   -0.27%     
+ Complexity     1857     1856       -1     
============================================
  Files           255      255              
  Lines         10261    10265       +4     
  Branches       1517     1518       +1     
============================================
- Hits           8013     7989      -24     
- Misses         1429     1456      +27     
- Partials        819      820       +1     
Impacted Files Coverage Δ
...arch/indexmanagement/rollup/RollupMapperService.kt 58.55% <57.14%> (-0.32%) ⬇️
...statemanagement/model/destination/CustomWebhook.kt 65.21% <0.00%> (-28.99%) ⬇️
...ent/rollup/action/explain/ExplainRollupResponse.kt 75.00% <0.00%> (-10.00%) ⬇️
...anagement/indexstatemanagement/model/Transition.kt 63.07% <0.00%> (-4.62%) ⬇️
...rch/indexmanagement/rollup/model/RollupMetadata.kt 83.33% <0.00%> (-1.79%) ⬇️
...ensearch/indexmanagement/rollup/model/ISMRollup.kt 93.04% <0.00%> (-1.74%) ⬇️
...ndexstatemanagement/IndexStateManagementHistory.kt 80.32% <0.00%> (-1.64%) ⬇️
...earch/indexmanagement/transform/model/Transform.kt 89.11% <0.00%> (-1.04%) ⬇️
...dexmanagement/transform/model/TransformMetadata.kt 90.36% <0.00%> (+3.61%) ⬆️
...arch/indexmanagement/rollup/RollupSearchService.kt 66.66% <0.00%> (+3.92%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e70b25...7cd61b7. Read the comment docs.

@thalurur thalurur merged commit 95238f8 into opensearch-project:main Jun 10, 2021
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
ask-kamal-nayan pushed a commit to ask-kamal-nayan/index-management that referenced this pull request May 22, 2025
# This is the 1st commit message:

Removed unnecessary user notifications for version conflict exceptions in Snapshot Management

Signed-off-by: Kamal Nayan <askkamal@amazon.com>

# This is the commit message opensearch-project#2:

Unwrapped the exception

Signed-off-by: Kamal Nayan <askkamal@amazon.com>

# This is the commit message opensearch-project#3:

Added the unit tests and updated the code

Signed-off-by: Kamal Nayan <askkamal@amazon.com>

# This is the commit message opensearch-project#4:

Updated the code for minor fixes and nits

Signed-off-by: Kamal Nayan <askkamal@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants