Adding SPI to support extensions of IndexManagement plugin #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
thalurur
force-pushed
the
development-extension
branch
from
3318630 to
c82793f
Compare
dbbaughe
approved these changes
Dec 8, 2021
downsrob
approved these changes
Dec 8, 2021
downsrob
pushed a commit
to downsrob/index-management
that referenced
this pull request
Mar 8, 2022
Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com> Base commit to clean up old action interfaces and disabling all ISM related tests (opensearch-project#218) Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com> Implement DeleteAcion using new interface (opensearch-project#221) Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com> Adding base logic to transition step to enable policy execution (opensearch-project#223) Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com> Support close action using new interface (opensearch-project#224) * Implement close action Signed-off-by: Annie Lee <leeyun@amazon.com> * Update functions Signed-off-by: Annie Lee <leeyun@amazon.com> * Update AttemptCloseStepTests.kt Signed-off-by: Annie Lee <leeyun@amazon.com> * Mark a test as private for now Since TransitionAction is not yet implemented. Marking a test as private to avoid integ test failure Signed-off-by: Annie Lee <leeyun@amazon.com> * Update CloseActionIT.kt Signed-off-by: Annie Lee <leeyun@amazon.com> Implement ReadOnlyAction using new interface (opensearch-project#227) * Refactors ReadOnlyAction Signed-off-by: Robert Downs <downsrob@amazon.com> Implement ReadWriteAction using new interface (opensearch-project#228) Signed-off-by: Clay Downs <downsrob@amazon.com> Implement OpenAction using new interface (opensearch-project#230) * Support open action Signed-off-by: Annie Lee <leeyun@amazon.com> * Update AttemptOpenStep.kt Signed-off-by: Annie Lee <leeyun@amazon.com> * Add close action test Signed-off-by: Annie Lee <leeyun@amazon.com> * Add open action related tests Signed-off-by: Annie Lee <leeyun@amazon.com> * Add open action test round trip Signed-off-by: Annie Lee <leeyun@amazon.com> * Fix open action xcontent test Signed-off-by: Annie Lee <leeyun@amazon.com> * Modify XContentTests for better comparison Signed-off-by: Annie Lee <leeyun@amazon.com> * Update XContentTests.kt Signed-off-by: Annie Lee <leeyun@amazon.com> Implements RolloverAction with new interface, fixes default action retry commit (opensearch-project#231) * Implements rollover action with new interface, fixes default action retry Signed-off-by: Clay Downs <downsrob@amazon.com> Support ReplicaCountAction using new interface (opensearch-project#233) Signed-off-by: Annie Lee <leeyun@amazon.com> Refactors rollup action and enables multi step actions (opensearch-project#235) Signed-off-by: Robert Downs <downsrob@amazon.com> Refactors Notification action with new interface (opensearch-project#238) * Refactors notification action with new interface Signed-off-by: Robert Downs <downsrob@amazon.com> Upgrades detekt version, fixes flaky tests (opensearch-project#254) * Upgrades detekt version to 1.17.1 (opensearch-project#252) * Adds detekt ignores to not-yet-refactored files * Fixes flaky rollup/transform explain IT (opensearch-project#247) Signed-off-by: Robert Downs <downsrob@amazon.com> Support force merge action using new interface (opensearch-project#256) * Support force merge action Signed-off-by: Annie Lee <leeyun@amazon.com> Refactors Snapshot action to use new interface (opensearch-project#253) * Refactors snapshot action to use new interface Signed-off-by: Clay Downs <downsrob@amazon.com> Support index priority action using new interface (opensearch-project#257) Signed-off-by: Annie Lee <leeyun@amazon.com> Support Allocation action using new interface (opensearch-project#246) * Support Allocation action using new interface Signed-off-by: Annie Lee <leeyun@amazon.com> * Pass in required parameter Signed-off-by: Annie Lee <leeyun@amazon.com> * Update AttemptAllocationStep.kt Adding correct const Signed-off-by: Annie Lee <leeyun@amazon.com> * Update AttemptAllocationStep.kt Typo in message Signed-off-by: Annie Lee <leeyun@amazon.com> * Debug tests Signed-off-by: Annie Lee <leeyun@amazon.com> * Update XContentTests.kt Signed-off-by: Annie Lee <leeyun@amazon.com> * Revert "Debug tests" This reverts commit d7123bd. Signed-off-by: Annie Lee <leeyun@amazon.com> * Update IndexPolicyRequestTests.kt Signed-off-by: Annie Lee <leeyun@amazon.com> * Support force merge action using new interface (opensearch-project#256) * Support force merge action Signed-off-by: Annie Lee <leeyun@amazon.com> * Update AllocationActionIT.kt Signed-off-by: Annie Lee <leeyun@amazon.com> * Revert "Update IndexPolicyRequestTests.kt" This reverts commit bd34e2e. Signed-off-by: Annie Lee <leeyun@amazon.com> * Add debug log Signed-off-by: Annie Lee <leeyun@amazon.com> * Remove debug log and change order of parameters Signed-off-by: Annie Lee <leeyun@amazon.com> * Update after comments Fix order of include exclude parameter in parser Add check to tests Remove "Config" in message Signed-off-by: Annie Lee <leeyun@amazon.com> Merging changes from main branch (opensearch-project#259) Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com> merge with main (opensearch-project#270) Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com> Adds custom action parsing (opensearch-project#273) * Adds custom action parsing logic Signed-off-by: Robert Downs <downsrob@amazon.com> Refactor coordinator to support create and delete index events when different index types exist on cluster (opensearch-project#272) * Refactor coordinator to support different index type create and delete events and sweep Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com> introducing custom uuid setting in SPI (opensearch-project#278) * introducing custom uuid setting in SPI Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com> Refactors the managed index runner to work with extensions (opensearch-project#262) * Adds index creation date Signed-off-by: Robert Downs <downsrob@amazon.com> Adds NewClusterEventListeners and refactors Transition to work with custom actions Signed-off-by: Robert Downs <downsrob@amazon.com> Marks blocked actions list as deprecated Signed-off-by: Clay Downs <89109232+downsrob@users.noreply.github.com> Asserts the deprecation warning after adding to allow list in test Signed-off-by: Robert Downs <downsrob@amazon.com> Removes allow_list test Signed-off-by: Robert Downs <downsrob@amazon.com> * Fix additional rebase issues Signed-off-by: Robert Downs <downsrob@amazon.com> * Fixes failing tests Signed-off-by: Robert Downs <downsrob@amazon.com> * changes based on comments Signed-off-by: Robert Downs <downsrob@amazon.com> * Adds additional comments Signed-off-by: Clay Downs <89109232+downsrob@users.noreply.github.com> Makes rest APIs use new metadata service (opensearch-project#245) * Makes rest API use new metadata service Signed-off-by: Robert Downs <downsrob@amazon.com> Adds missed flags (opensearch-project#286) Signed-off-by: Clay Downs <89109232+downsrob@users.noreply.github.com> Ports over show-applied-policies logic (opensearch-project#287) Signed-off-by: Clay Downs <89109232+downsrob@users.noreply.github.com>
downsrob
added a commit
that referenced
this pull request
Mar 9, 2022
* Adding IM SPI (#216) Signed-off-by: Robert Downs <downsrob@amazon.com> Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com>
downsrob
added a commit
to downsrob/index-management
that referenced
this pull request
Mar 9, 2022
…t#288) * Adding IM SPI (opensearch-project#216) Signed-off-by: Robert Downs <downsrob@amazon.com> Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com>
downsrob
added a commit
to downsrob/index-management
that referenced
this pull request
Mar 9, 2022
…t#288) * Adding IM SPI (opensearch-project#216) Signed-off-by: Robert Downs <downsrob@amazon.com> Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com> Signed-off-by: Robert Downs <downsrob@amazon.com>
downsrob
added a commit
that referenced
this pull request
Mar 9, 2022
* Adding IM SPI (#216) Signed-off-by: Robert Downs <downsrob@amazon.com> Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com> Signed-off-by: Robert Downs <downsrob@amazon.com>
wuychn
pushed a commit
to ochprince/index-management
that referenced
this pull request
Mar 16, 2023
…t#288) * Adding IM SPI (opensearch-project#216) Signed-off-by: Robert Downs <downsrob@amazon.com> Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ravi Thaluru thalurur@users.noreply.github.com
Issue #, if available:
N/A
Description of changes:
The new SPI will help enable custom ISM actions inside ISM policies and also enable support to handle custom index types if needed.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.