-
Couldn't load subscription status.
- Fork 130
Settings Backwards Compatibility #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings Backwards Compatibility #16
Conversation
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
fbe323e to
b8db246
Compare
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
============================================
+ Coverage 76.84% 77.57% +0.72%
- Complexity 1559 1560 +1
============================================
Files 199 201 +2
Lines 8395 8588 +193
Branches 1323 1326 +3
============================================
+ Hits 6451 6662 +211
+ Misses 1246 1224 -22
- Partials 698 702 +4
Continue to review full report at Codecov.
|
* Renaming, and Backwards Compatibility for Settings Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Issue #, if available:
#11
Description of changes:
Cluster setting is updated to legacy setting because there is
clusterService.clusterSettings.addSettingsUpdateConsumerAs DB mentioned here, this consumer can update the setting to legacy setting when OpenSearch node joins the cluster
But for index setting, there is no such consumer. So we will need read from 2 places (_plugins first, if not exist, read _opendistro one); and only write to _opendistro. This will not break customer's existing use case.
CheckList:
[ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.