Removed unnecessary user notifications for version conflict exception #1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ask-kamal-nayan
requested review from
Hailong-am,
bowenlan-amzn,
shiv0408,
soosinha,
tandonks and
vikasvb90
as code owners
shourya035
approved these changes
May 6, 2025
ashking94
reviewed
May 6, 2025
src/main/kotlin/org/opensearch/indexmanagement/snapshotmanagement/engine/SMStateMachine.kt
Outdated
Show resolved
Hide resolved
Hailong-am
reviewed
May 8, 2025
src/main/kotlin/org/opensearch/indexmanagement/snapshotmanagement/engine/SMStateMachine.kt
Outdated
Show resolved
Hide resolved
ask-kamal-nayan
force-pushed
the
user/askkamal/ss
branch
from
da59068 to
7dd617c
Compare
src/main/kotlin/org/opensearch/indexmanagement/snapshotmanagement/engine/SMStateMachine.kt
Outdated
Show resolved
Hide resolved
ask-kamal-nayan
force-pushed
the
user/askkamal/ss
branch
from
f445173 to
5bcb569
Compare
src/test/kotlin/org/opensearch/indexmanagement/snapshotmanagement/engine/SMStateMachineTests.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/opensearch/indexmanagement/snapshotmanagement/engine/SMStateMachineTests.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/opensearch/indexmanagement/snapshotmanagement/engine/SMStateMachineTests.kt
Outdated
Show resolved
Hide resolved
ask-kamal-nayan
commented
May 21, 2025
src/test/kotlin/org/opensearch/indexmanagement/snapshotmanagement/engine/SMStateMachineTests.kt
Show resolved
Hide resolved
ask-kamal-nayan
force-pushed
the
user/askkamal/ss
branch
2 times, most recently
from
f75852f to
dadf888
Compare
…s in Snapshot Management Signed-off-by: Kamal Nayan <askkamal@amazon.com> Unwrapped the exception Signed-off-by: Kamal Nayan <askkamal@amazon.com> Added the unit tests and updated the code Signed-off-by: Kamal Nayan <askkamal@amazon.com> Updated the code for minor fixes and nits Signed-off-by: Kamal Nayan <askkamal@amazon.com> Updated the unit Test Signed-off-by: Kamal Nayan <askkamal@amazon.com> Updated access modifier for the updateMetaDataRetryPolicy Signed-off-by: Kamal Nayan <askkamal@amazon.com>
ask-kamal-nayan
force-pushed
the
user/askkamal/ss
branch
from
dadf888 to
cfa5f68
Compare
bowenlan-amzn
approved these changes
May 22, 2025
bowenlan-amzn
merged commit 4ef0f4f
into
opensearch-project:main
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The manual snapshot policy management system needs modification to prevent false alarm notifications caused by internal version conflict exceptions during concurrent snapshot operations.
GitHub Issue Reference
Current Behavior:
Proposed Changes:
Modify exception handling to suppress notifications for VersionConflictEngineException just log this as error message.
Maintain notifications for all other exception type
Related Issues
GitHub Issue Reference
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.