Fix snapshot build, build against OpenSearch 1.1. #119
Conversation
dblock
force-pushed
the
fix-snapshot-build
branch
3 times, most recently
from
8f00300
to
edef829
Compare
dblock
force-pushed
the
fix-snapshot-build
branch
2 times, most recently
from
0a141fd
to
32a68f3
Compare
dblock
force-pushed
the
fix-snapshot-build
branch
4 times, most recently
from
0ffae38
to
2df17c4
Compare
dblock
force-pushed
the
fix-snapshot-build
branch
4 times, most recently
from
3614bfa
to
388d297
Compare
Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
fix-snapshot-build
branch
from
388d297
to
b4374eb
Compare
Codecov Report
@@ Coverage Diff @@
## main #119 +/- ##
============================================
- Coverage 75.46% 75.20% -0.26%
+ Complexity 1898 1893 -5
============================================
Files 262 262
Lines 10934 10934
Branches 1734 1734
============================================
- Hits 8251 8223 -28
- Misses 1727 1758 +31
+ Partials 956 953 -3
Continue to review full report at Codecov.
|
|
I'd like to keep the test resources checked in for development. Trying to limit all of the extra hacky work needed for someone pulling down a plugin. Yes, the checked in plugin is stale compared to potentially what's on the branch in the dependent plugin repo, but even if they check that out and build locally it immediately becomes "stale" too and they would have to always make sure they rebuild to have the "latest" whenever there are changes in the other repositories. |
| # index-management | ||
| - name: Checkout Branch | ||
| uses: actions/checkout@v2 | ||
| repository: 'dblock/notifications' |
There was a problem hiding this comment.
Was this leftover for testing? Can we change this back to the official repo?
| # index-management | ||
| - name: Checkout Branch | ||
| uses: actions/checkout@v2 | ||
| repository: 'dblock/notifications' |
|
Replaced by #121 |
opensearch-project#119) * Update opendistro-for-elasticsearch-index-management-kibana-plugin.release-notes-1.10.0.0.md * paranthesis
Signed-off-by: dblock dblock@amazon.com
Fixes #116 and #112.
Builds job-scheduler and notifications in-line instead of having to commit plugin artifacts.
CheckList:
[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.