Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Ensure the OSD server starts before cypress test running #960

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kohinoor98
Copy link
Contributor

@kohinoor98 kohinoor98 commented Jan 6, 2024

Description

The two approaches mentioned in #938 have been implemented.

Approach 1:
Wait for api/status to return 200 and then check if the status is 'green'

Approach 2:
Add locahost:9200 in the wait-on conditions

Issues Resolved

#938

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.37%. Comparing base (8a385b8) to head (3330988).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #960   +/-   ##
=======================================
  Coverage   63.37%   63.37%           
=======================================
  Files         341      341           
  Lines       11554    11554           
  Branches     2243     2243           
=======================================
  Hits         7322     7322           
  Misses       3658     3658           
  Partials      574      574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kohinoor98 <kohinoorchatterjee1998@gmail.com>
@r1walz r1walz force-pushed the #938_server_starts_before_cypress_test branch from 781d4a8 to 3330988 Compare March 18, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant