update backport branch name #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong and
SuZhou-Joe
as code owners
Codecov Report
@@ Coverage Diff @@
## main #837 +/- ##
==========================================
- Coverage 63.37% 63.36% -0.01%
==========================================
Files 341 341
Lines 11545 11553 +8
Branches 2108 2112 +4
==========================================
+ Hits 7317 7321 +4
- Misses 3654 3658 +4
Partials 574 574 |
bowenlan-amzn
approved these changes
Aug 4, 2023
Comment on lines
+11
to
+19
| if: > | ||
| github.event.pull_request.merged | ||
| && ( | ||
| github.event.action == 'closed' | ||
| || ( | ||
| github.event.action == 'labeled' | ||
| && contains(github.event.label.name, 'backport') | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Curious why adding these part now?
There was a problem hiding this comment.
Add this condition will only react to merged PRs for security reasons. see more https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target
here is the example VachaShah/backport@fb9853c#diff-1b2ad8b0da1ad4fac7eb4ef8cdeed82b48d00a80eb531a6f31db11f73182f491R12
SuZhou-Joe
approved these changes
Aug 7, 2023
gaobinlong
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update backport branch name as
branch_namewas deprecatedIssues Resolved
follow up changes for #821
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.