Fixed repo name in snapshot flyout; Use schedule from policy during edit #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am and
SuZhou-Joe
as code owners
getsaurabh02
approved these changes
Jul 21, 2023
|
Can we get some unit test for this? |
Codecov Report
@@ Coverage Diff @@
## main #824 +/- ##
==========================================
- Coverage 63.38% 63.36% -0.02%
==========================================
Files 341 341
Lines 11545 11553 +8
Branches 2108 2112 +4
==========================================
+ Hits 7318 7321 +3
- Misses 3654 3658 +4
- Partials 573 574 +1 |
bowenlan-amzn
approved these changes
Jul 22, 2023
| @@ -55,6 +55,25 @@ const CronSchedule = ({ | |||
| const [dayOfWeek, setWeek] = useState(initWeek); | |||
| const [dayOfMonth, setMonth] = useState(initMonth); | |||
|
|
|||
| // When edit policy is clicked, during the initial render DEFAULT values get passed | |||
There was a problem hiding this comment.
The miss here is thought useState will re-create those values every time
This was referenced Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes below issues:
Issues Resolved
#823 , #822
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.