Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix common funcs: status filter, empty response #753

Merged
merged 2 commits into from
May 23, 2023

Conversation

zhichao-aws
Copy link
Member

Description

Fix the problem when reponse is undefined; only filter out red indices in open status

Issues Resolved

see #751

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: zhichao-aws <zhichaog@amazon.com>
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #753 (a54dd8d) into main (7581b95) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
+ Coverage   58.97%   58.99%   +0.01%     
==========================================
  Files         318      318              
  Lines       10606    10610       +4     
  Branches     2025     2027       +2     
==========================================
+ Hits         6255     6259       +4     
  Misses       3833     3833              
  Partials      518      518              

see 1 file with indirect coverage changes

xluo-aws
xluo-aws previously approved these changes May 23, 2023
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
@Hailong-am Hailong-am merged commit 9d4cdd9 into opensearch-project:main May 23, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-753-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9d4cdd983a5d1212a0006781d3a8cf2125d58b43
# Push it to GitHub
git push --set-upstream origin backport/backport-753-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-753-to-2.x.

zhichao-aws added a commit to zhichao-aws/index-management-dashboards-plugin that referenced this pull request May 24, 2023
* fix common funcs: status filter, empty response

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

* also filter case null and empty string

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

---------

Signed-off-by: zhichao-aws <zhichaog@amazon.com>
(cherry picked from commit 9d4cdd9)
SuZhou-Joe pushed a commit that referenced this pull request May 24, 2023
* fix common funcs: status filter, empty response

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

* also filter case null and empty string

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

---------

Signed-off-by: zhichao-aws <zhichaog@amazon.com>
(cherry picked from commit 9d4cdd9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants