-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix common funcs: status filter, empty response #753
Merged
Hailong-am
merged 2 commits into
opensearch-project:main
from
zhichao-aws:fix_common_funcs
May 23, 2023
Merged
fix common funcs: status filter, empty response #753
Hailong-am
merged 2 commits into
opensearch-project:main
from
zhichao-aws:fix_common_funcs
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
zhichao-aws
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am and
SuZhou-Joe
as code owners
May 23, 2023 07:52
Codecov Report
@@ Coverage Diff @@
## main #753 +/- ##
==========================================
+ Coverage 58.97% 58.99% +0.01%
==========================================
Files 318 318
Lines 10606 10610 +4
Branches 2025 2027 +2
==========================================
+ Hits 6255 6259 +4
Misses 3833 3833
Partials 518 518 |
xluo-aws
previously approved these changes
May 23, 2023
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Hailong-am
approved these changes
May 23, 2023
xluo-aws
approved these changes
May 23, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-753-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9d4cdd983a5d1212a0006781d3a8cf2125d58b43
# Push it to GitHub
git push --set-upstream origin backport/backport-753-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
zhichao-aws
added a commit
to zhichao-aws/index-management-dashboards-plugin
that referenced
this pull request
May 24, 2023
* fix common funcs: status filter, empty response Signed-off-by: zhichao-aws <zhichaog@amazon.com> * also filter case null and empty string Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com> (cherry picked from commit 9d4cdd9)
SuZhou-Joe
pushed a commit
that referenced
this pull request
May 24, 2023
* fix common funcs: status filter, empty response Signed-off-by: zhichao-aws <zhichaog@amazon.com> * also filter case null and empty string Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com> (cherry picked from commit 9d4cdd9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the problem when reponse is
undefined
; only filter out red indices inopen status
Issues Resolved
see #751
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.