Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update path parameter to follow RFC/generic HTTP convention (#737) #744

Merged

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented May 17, 2023

  • Update path parameter to follow RFC/generic HTTP convention

Signed-off-by: suzhou suzhou@amazon.com

  • Update path parameter to follow RFC/generic HTTP convention

Signed-off-by: suzhou suzhou@amazon.com


Signed-off-by: suzhou suzhou@amazon.com
(cherry picked from commit a4a6a8d)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ch-project#737)

* Update path parameter to follow RFC/generic HTTP convention

Signed-off-by: suzhou <suzhou@amazon.com>

* Update path parameter to follow RFC/generic HTTP convention

Signed-off-by: suzhou <suzhou@amazon.com>

---------

Signed-off-by: suzhou <suzhou@amazon.com>
(cherry picked from commit a4a6a8d)
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #744 (40a20e9) into 2.6 (120911c) will not change coverage.
The diff coverage is n/a.

❗ Current head 40a20e9 differs from pull request most recent head 74f1f90. Consider uploading reports for the commit 74f1f90 to get more accurate results

@@           Coverage Diff            @@
##              2.6     #744    +/-   ##
========================================
  Coverage   59.46%   59.46%            
========================================
  Files         291      291            
  Lines        9680     9680            
  Branches     1702     1804   +102     
========================================
  Hits         5756     5756            
  Misses       3476     3476            
  Partials      448      448            

@SuZhou-Joe
Copy link
Member Author

image
E2E test screenshot

@SuZhou-Joe SuZhou-Joe force-pushed the backport/backport-737-to-2.6 branch from 40a20e9 to 74f1f90 Compare May 18, 2023 02:56
@SuZhou-Joe SuZhou-Joe merged commit 0b7fc0b into opensearch-project:2.6 May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants