Updating the maintainers and CODEOWNERS file #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bbarani <bbarani@amazon.com>
SuZhou-Joe
reviewed
May 10, 2023
.github/CODEOWNERS
Outdated
| @@ -1,4 +1,3 @@ | |||
| @bowenlan-amzn | |||
| @Angie-Zhang | |||
| @getsaurabh02 | |||
| @praveensameneni | |||
There was a problem hiding this comment.
Suggested change
| @praveensameneni | |
| @praveensameneni | |
| @xluo-aws | |
| @gaobinlong | |
| @Hailong-am | |
| @SuZhou-Joe |
There was a problem hiding this comment.
This is the wrong format, should be a * ...list.
SuZhou-Joe
reviewed
May 10, 2023
| @@ -7,6 +7,5 @@ This document contains a list of maintainers in this repo. See [opensearch-proje | |||
| | Maintainer | GitHub ID | Affiliation | | |||
| |----------|---------------------------------------------------| ----------- | | |||
| | Bowen Lan | [bowenlan-amzn](https://github.com/bowenlan-amzn) | Amazon | | |||
| | Angie Zhang | [Angie-Zhang](https://github.com/Angie-Zhang) | Amazon | | |||
| | Saurabh Singh | [getsaurabh02](https://github.com/getsaurabh02) | Amazon | | |||
| | Praveen Sameneni | [praveensameneni](https://github.com/praveensameneni) | Amazon | | |||
There was a problem hiding this comment.
Suggested change
| | Praveen Sameneni | [praveensameneni](https://github.com/praveensameneni) | Amazon | | |
| | Praveen Sameneni | [praveensameneni](https://github.com/praveensameneni) | Amazon | | |
| | Xuesong Luo | [xluo-aws](https://github.com/xluo-aws) | Amazon | | |
| | Hailong Cui | [Hailong-am](https://github.com/Hailong-am) | Amazon | | |
| | Binlong Gao | [gaobinlong](https://github.com/gaobinlong) | Amazon | | |
| | Zhou Su | [SuZhou-Joe](https://github.com/SuZhou-Joe) | Amazon | |
There was a problem hiding this comment.
Let's add new maintainers after the baselining exercise.
|
@opensearch-project/admin |
Signed-off-by: bbarani <bbarani@amazon.com>
|
@SuZhou-Joe Just trying to match permissions. We'll sync to what's currently in MAINTAINERS and you can add/remove people following the standard process as you see fit after this. |
dblock
previously approved these changes
May 10, 2023
Signed-off-by: bbarani <bbarani@amazon.com>
dblock
approved these changes
May 10, 2023
prudhvigodithi
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the MAINTAINERS.md and CODEOWNERS file
Issues Resolved
Closes #610
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.