Fix: bugs during internal bugathon and fix the alias deletion issue in security mode. #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #704 +/- ##
==========================================
- Coverage 58.97% 58.74% -0.23%
==========================================
Files 296 318 +22
Lines 9806 10543 +737
Branches 1826 2011 +185
==========================================
+ Hits 5783 6194 +411
- Misses 3572 3833 +261
- Partials 451 516 +65 see 49 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: suzhou <suzhou@amazon.com>
gaobinlong
reviewed
Apr 14, 2023
| @@ -44,14 +45,25 @@ export default function DeleteAliasModal(props: DeleteAliasModalProps) { | |||
| const onConfirm = useCallback(async () => { | |||
| if (services) { | |||
| const result = await services.commonService.apiCaller({ | |||
| endpoint: "indices.deleteAlias", | |||
| endpoint: "indices.updateAliases", | |||
There was a problem hiding this comment.
Why not using delete alias API and specifying concrete index names to delete all of the aliases, maybe simpler than this?
There was a problem hiding this comment.
I was not sure what the expression will be like if there are multiple indexes + multiple aliases. But after some testing I found it works well. Will change to that approach.
Hailong-am
reviewed
Apr 14, 2023
public/pages/IndexDetail/containers/IndexDetail/IndexDetail.tsx
Outdated
Show resolved
Hide resolved
xluo-aws
reviewed
Apr 14, 2023
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Hailong-am
approved these changes
Apr 17, 2023
gaobinlong
approved these changes
Apr 17, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
…n security mode. (#704) * feat: Update Template Detail snapshot Signed-off-by: suzhou <suzhou@amazon.com> * feat: Update helpText for component template Signed-off-by: suzhou <suzhou@amazon.com> * fix: expand size for search index Signed-off-by: suzhou <suzhou@amazon.com> * feat: enable removeWhenEmpty on index setting Signed-off-by: suzhou <suzhou@amazon.com> * feat: add empty remove in component template Signed-off-by: suzhou <suzhou@amazon.com> * feat: enable duplicate mappings Signed-off-by: suzhou <suzhou@amazon.com> * fix: remove alias in security mode Signed-off-by: suzhou <suzhou@amazon.com> * feat: update release-notes Signed-off-by: suzhou <suzhou@amazon.com> * feat: fix unit test cases Signed-off-by: suzhou <suzhou@amazon.com> * feat: change to a simpler approach Signed-off-by: suzhou <suzhou@amazon.com> * feat: add exactSearch in getIndices method Signed-off-by: suzhou <suzhou@amazon.com> * feat: change unit test Signed-off-by: suzhou <suzhou@amazon.com> * feat: modify replicas Signed-off-by: suzhou <suzhou@amazon.com> --------- Signed-off-by: suzhou <suzhou@amazon.com> (cherry picked from commit 1503264)
SuZhou-Joe
added a commit
that referenced
this pull request
Apr 19, 2023
…n security mode. (#704) (#707) * feat: Update Template Detail snapshot Signed-off-by: suzhou <suzhou@amazon.com> * feat: Update helpText for component template Signed-off-by: suzhou <suzhou@amazon.com> * fix: expand size for search index Signed-off-by: suzhou <suzhou@amazon.com> * feat: enable removeWhenEmpty on index setting Signed-off-by: suzhou <suzhou@amazon.com> * feat: add empty remove in component template Signed-off-by: suzhou <suzhou@amazon.com> * feat: enable duplicate mappings Signed-off-by: suzhou <suzhou@amazon.com> * fix: remove alias in security mode Signed-off-by: suzhou <suzhou@amazon.com> * feat: update release-notes Signed-off-by: suzhou <suzhou@amazon.com> * feat: fix unit test cases Signed-off-by: suzhou <suzhou@amazon.com> * feat: change to a simpler approach Signed-off-by: suzhou <suzhou@amazon.com> * feat: add exactSearch in getIndices method Signed-off-by: suzhou <suzhou@amazon.com> * feat: change unit test Signed-off-by: suzhou <suzhou@amazon.com> * feat: modify replicas Signed-off-by: suzhou <suzhou@amazon.com> --------- Signed-off-by: suzhou <suzhou@amazon.com> (cherry picked from commit 1503264) Co-authored-by: suzhou <suzhou@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.