Add support for codeowners to repo #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
39 tasks
| @@ -0,0 +1,2 @@ | |||
| # This should match the owning team set up in https://github.com/orgs/opensearch-project/teams | |||
| * @opensearch-project/engineering-effectiveness | |||
There was a problem hiding this comment.
Does it matter if you have multiple space between * and @?
|
@ryanbogan Any updates on this? Looks like it is lying stale since a long time here. |
|
I used the same formatting for every repo and did not encounter any problems so I do not believe that the spacing matters. |
peterzhuamazon
approved these changes
Feb 20, 2022
|
@bbarani please approve. Thanks. |
bbarani
approved these changes
Feb 20, 2022
mkhpalm
pushed a commit
to mkhpalm/opensearch-helm-charts
that referenced
this pull request
Feb 22, 2022
Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Mike Palmer <mpalmer@terascope.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Bogan rbogan@amazon.com
Description
Add support for codeowners to repo
Issues Resolved
Progress on:
Meta issue
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.