Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky testGeoHexGridBucket #630

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

ryanbogan
Copy link
Member

Description

Temporarily changes the max precision to 14 instead of 15, since there is a bug that fails on 15

Issue created for bug: #629

Issues Resolved

#619

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c9ea964) 89.03% compared to head (2aa7e40) 89.14%.

Additional details and impacted files
@@             Coverage Diff              @@
##               2.12     #630      +/-   ##
============================================
+ Coverage     89.03%   89.14%   +0.10%     
- Complexity      767      768       +1     
============================================
  Files            93       93              
  Lines          2746     2746              
  Branches        223      223              
============================================
+ Hits           2445     2448       +3     
+ Misses          221      219       -2     
+ Partials         80       79       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@VijayanB VijayanB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this bug is not release blocker, approving this PR.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@martin-gaievski martin-gaievski merged commit 0186b99 into opensearch-project:2.12 Feb 15, 2024
28 of 29 checks passed
@ryanbogan ryanbogan deleted the fix_flaky branch February 15, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants