Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to use jdk-21 #599

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

ryanbogan
Copy link
Member

Description

This updates the CI system to use jdk-21, which is latest LTS supported version.
Coming from opensearch-project/OpenSearch#10334

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70f6751) 89.03% compared to head (11fabde) 89.14%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #599      +/-   ##
============================================
+ Coverage     89.03%   89.14%   +0.10%     
- Complexity      767      768       +1     
============================================
  Files            93       93              
  Lines          2746     2746              
  Branches        223      223              
============================================
+ Hits           2445     2448       +3     
+ Misses          221      219       -2     
+ Partials         80       79       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@heemin32 heemin32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@junqiu-lei junqiu-lei merged commit 34aec65 into opensearch-project:main Dec 26, 2023
27 of 28 checks passed
@ryanbogan ryanbogan deleted the add_jdk21_support branch December 26, 2023 18:48
@ryanbogan ryanbogan added the backport 2.x Backport PR to 2.x branch label Dec 26, 2023
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-599-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 34aec653efb7f17a68c89da9fb7ce53b25b896d0
# Push it to GitHub
git push --set-upstream origin backport/backport-599-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-599-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport PR to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants