Add integration test against security enabled cluster #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemin32
requested review from
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
heemin32
added
backport 2.x
Codecov Report
@@ Coverage Diff @@
## main #513 +/- ##
============================================
- Coverage 88.62% 88.47% -0.15%
- Complexity 751 752 +1
============================================
Files 92 92
Lines 2717 2717
Branches 221 221
============================================
- Hits 2408 2404 -4
- Misses 228 232 +4
Partials 81 81 |
heemin32
force-pushed
the
security
branch
2 times, most recently
from
ba33c8a
to
209bb34
Compare
Signed-off-by: Heemin Kim <heemin@amazon.com>
vibrantvarun
approved these changes
Oct 5, 2023
junqiu-lei
approved these changes
Oct 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit ed8198f)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit ed8198f)
|
Just to make sure we're keeping in mind that this approach has multiple drawbacks, main one would be that if some core component is failing then this action will fail too, we've seen that in knn repo, @heemin32 I mean discussion in this issue: opensearch-project/k-NN#901 |
heemin32
added a commit
that referenced
this pull request
Oct 5, 2023
heemin32
added a commit
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add integration test against security enabled cluster
Issues Resolved
#512
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.