Changes in invalid input handling #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemin32
requested review from
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
1. Switch exception type from OpenSearchException to IllegalArgumentException for invalid endpoint 2. Add cluster state validation for update API Signed-off-by: Heemin Kim <heemin@amazon.com>
martin-gaievski
approved these changes
Jul 28, 2023
Codecov Report
@@ Coverage Diff @@
## main #373 +/- ##
============================================
- Coverage 88.65% 88.60% -0.06%
Complexity 752 752
============================================
Files 92 92
Lines 2707 2711 +4
Branches 219 220 +1
============================================
+ Hits 2400 2402 +2
- Misses 228 230 +2
Partials 79 79
|
vamshin
reviewed
Jul 29, 2023
| @@ -94,6 +95,11 @@ protected void doExecute(final Task task, final UpdateDatasourceRequest request, | |||
| if (datasource == null) { | |||
| throw new ResourceNotFoundException("no such datasource exist"); | |||
| } | |||
| if (DatasourceState.AVAILABLE.equals(datasource.getState()) == false) { | |||
There was a problem hiding this comment.
Why not use if(!DatasourceState.....)?
There was a problem hiding this comment.
== false is more readable and preferred format borrowed from OpenSearch core.
junqiu-lei
approved these changes
Jul 31, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
1. Switch exception type from OpenSearchException to IllegalArgumentException for invalid endpoint 2. Add cluster state validation for update API Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit e1f41bb)
heemin32
added a commit
that referenced
this pull request
Jul 31, 2023
1. Switch exception type from OpenSearchException to IllegalArgumentException for invalid endpoint 2. Add cluster state validation for update API Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit e1f41bb) Co-authored-by: Heemin Kim <heemin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.