Added input parameter validation with few small changes #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added datasource name validation in delete/update api 2. Added datasource name validation in processor creation method 3. Changed index name delimiter from `.` to `-` to be consistent with others Signed-off-by: Heemin Kim <heemin@amazon.com>
heemin32
requested review from
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
martin-gaievski
approved these changes
Jul 27, 2023
junqiu-lei
approved these changes
Jul 27, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
1. Added datasource name validation in delete/update api 2. Added datasource name validation in processor creation method 3. Changed index name delimiter from `.` to `-` to be consistent with others Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit 0cfddbf)
heemin32
added a commit
that referenced
this pull request
Jul 27, 2023
1. Added datasource name validation in delete/update api 2. Added datasource name validation in processor creation method 3. Changed index name delimiter from `.` to `-` to be consistent with others Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit 0cfddbf) Co-authored-by: Heemin Kim <heemin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.to-to be consistent with othersIssues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.