Have FlowFrameworkException status recognized by ExceptionsHelper #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
============================================
+ Coverage 75.77% 75.82% +0.04%
- Complexity 834 838 +4
============================================
Files 88 88
Lines 4046 4054 +8
Branches 373 373
============================================
+ Hits 3066 3074 +8
Misses 824 824
Partials 156 156 ☔ View full report in Codecov by Sentry. |
74 tasks
amitgalitz
approved these changes
Jul 26, 2024
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
jackiehanyang
approved these changes
Jul 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Have FlowFrameworkException status recognized by ExceptionsHelper Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add tests Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 7ec848a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Have FlowFrameworkException status recognized by ExceptionsHelper Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add tests Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 7ec848a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jackiehanyang
pushed a commit
that referenced
this pull request
Jul 26, 2024
…ptionsHelper (#817) Have FlowFrameworkException status recognized by ExceptionsHelper (#811) * Have FlowFrameworkException status recognized by ExceptionsHelper * Add tests --------- (cherry picked from commit 7ec848a) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jackiehanyang
pushed a commit
that referenced
this pull request
Jul 26, 2024
…tionsHelper (#816) Have FlowFrameworkException status recognized by ExceptionsHelper (#811) * Have FlowFrameworkException status recognized by ExceptionsHelper * Add tests --------- (cherry picked from commit 7ec848a) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While we have been careful to use
FlowFrameworkExceptionwith approporiate status codes, our refactoring near GA to use the OpenSearchExceptionsHelperwrapper ended up losing these and replacing them with 500 errors.See
OpenSearchStatusExceptionthat this essentially mimics.Related Issues
Fixes #810
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.