Allow lower NodeJS version on GH runners for security test #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
|
Spotless check failing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #765 +/- ##
============================================
- Coverage 74.37% 74.30% -0.08%
Complexity 745 745
============================================
Files 84 84
Lines 3825 3825
Branches 333 333
============================================
- Hits 2845 2842 -3
- Misses 825 829 +4
+ Partials 155 154 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Widdis <widdis@gmail.com>
amitgalitz
approved these changes
Jul 8, 2024
owaiskazi19
approved these changes
Jul 8, 2024
We are one of many plugins doing this. IT's being tracked here: opensearch-project/opensearch-build#4379 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit c76fb3a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jul 8, 2024
…test (#770) Allow lower NodeJS version on GH runners for security test (#765) (cherry picked from commit c76fb3a) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
added a commit
that referenced
this pull request
Aug 19, 2024
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
added a commit
that referenced
this pull request
Aug 20, 2024
* Increment version to 2.13.1-SNAPSHOT Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Downgrade macos CI to non-aarch64 runner Signed-off-by: Daniel Widdis <widdis@gmail.com> * Allow lower NodeJS version on GH runners for security test (#765) Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
pushed a commit
that referenced
this pull request
Oct 9, 2024
…test (#770) Allow lower NodeJS version on GH runners for security test (#765) (cherry picked from commit c76fb3a) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Increment version to 2.14.1-SNAPSHOT Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> * [Backport 2.x] Allow lower NodeJS version on GH runners for security test (#770) Allow lower NodeJS version on GH runners for security test (#765) (cherry picked from commit c76fb3a) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Temporary workaround for failing security test until container is updated
Issues Resolved
Fixes #759
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.