Silently ignore content on APIs that don't require it #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
amitgalitz,
jackiehanyang,
joshpalis,
ohltyler and
owaiskazi19
as code owners
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
force-pushed
the
consume-content
branch
from
0793954 to
98088e7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
============================================
- Coverage 72.39% 72.28% -0.11%
+ Complexity 684 680 -4
============================================
Files 82 82
Lines 3535 3532 -3
Branches 288 284 -4
============================================
- Hits 2559 2553 -6
- Misses 850 854 +4
+ Partials 126 125 -1 ☔ View full report in Codecov by Sentry. |
joshpalis
approved these changes
Apr 2, 2024
|
We should not backport it to 2.13 as the release date is today and there will be no new RC generation |
owaiskazi19
approved these changes
Apr 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit b246341) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Apr 2, 2024
…641) Silently ignore content on APIs that don't require it (#639) (cherry picked from commit b246341) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Despite code paths and unit tests showing otherwise, OpenSearch silently ignores the content (body) of a REST request that doesn't require it. We should do the same.
Issues Resolved
Fixes #638 (or at least doesn't give users a poor experience).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.