Skip to content

Conversation

@stevanbz
Copy link

@stevanbz stevanbz commented Aug 23, 2022

Signed-off-by: Stevan Buzejic buzejic.stevan@gmail.com

Description

Adds transform cluster related privileges to privilege list

Issues Resolved

#949

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@stevanbz stevanbz requested a review from a team as a code owner August 23, 2022 17:01
@Naarcha-AWS
Copy link
Contributor

@stevanbz: Thank you for your contribution. Have you verified that these transform permissions function? And if so, for what versions?

@stevanbz
Copy link
Author

. Have you verified that these transform permissions function? And if so, for what versions?
Hi and sorry for late response. Yes I verified that most of the permissions are working correctly. I did manual testing (played with users and roles via dashboard) and I also created security integration tests in this pr:
opensearch-project/index-management#474

I did tests on opensearch 2.1

@Naarcha-AWS
Copy link
Contributor

Thanks @stevanbz. Just a heads up, your commit requires the DCO sign-off to pass the PR check.
See fix DCO for details.

We'll need you to sign off before you can merge, as well as resolving the merge conflict.

@stevanbz
Copy link
Author

stevanbz commented Sep 1, 2022

Hi. Thanks for notifying me - I forgot to sign-off. I am resolving the conflicts now and I saw that new privilege naming is being used (at least for index management cluster related actions) where the opendistro keyword is being removed. I suppose I should follow the pattern for transform or? Tnx in advance

@stevanbz stevanbz force-pushed the bugfix/949-add-missing-transform-privileges branch from 70914d4 to 97b5f52 Compare September 2, 2022 08:58
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
@stevanbz stevanbz force-pushed the bugfix/949-add-missing-transform-privileges branch from 97b5f52 to e003ec0 Compare September 2, 2022 09:01
@Naarcha-AWS
Copy link
Contributor

@stevanbz: Following up, you're correct that we're trying to remove opendistro endpoints and permissions when we can. However, the security plugin is an exception. I did verify these permissions within the code of the security plugin.

@Naarcha-AWS
Copy link
Contributor

@stevanbz: I'm going to go ahead and close this and open a new PR.

@stevanbz
Copy link
Author

Hi @Naarcha-AWS and tnx for the response. One question: did you manage to open new PR?
If so, can you pls send me the link to the PR? tnx in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants