Quote all alphabetic defaults. #7660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
AMoo-Miki,
Naarcha-AWS,
dlvenable,
epugh,
hdhalter,
kolchfa-aws,
natebower,
stephen-crawford and
vagimeli
as code owners
1 task
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Naarcha-AWS
suggested changes
Jul 9, 2024
_api-reference/cat/cat-allocation.md
Outdated
| :--- | :--- | :--- | ||
| bytes | Byte size | Specify the units for byte size. For example, `7kb` or `6gb`. For more information, see [Supported units]({{site.url}}{{site.baseurl}}/opensearch/units/). | ||
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is false. | ||
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is `false`. |
There was a problem hiding this comment.
Suggested change
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is `false`. | |
| local | Boolean | Whether to return information from the local node only instead of from the cluster manager node. Default is `false`. |
_api-reference/cat/cat-aliases.md
Outdated
| Parameter | Type | Description | ||
| :--- | :--- | :--- | ||
| local | Boolean | Whether to return information from the local node only instead of from the master node. Default is false. | ||
| local | Boolean | Whether to return information from the local node only instead of from the master node. Default is `false`. |
There was a problem hiding this comment.
Suggested change
| local | Boolean | Whether to return information from the local node only instead of from the master node. Default is `false`. | |
| local | Boolean | Whether to return information from the local node only instead of from the cluster manager node. Default is `false`. |
_api-reference/cat/cat-nodeattrs.md
Outdated
| Parameter | Type | Description | ||
| :--- | :--- | :--- | ||
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is false. | ||
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is `false`. |
There was a problem hiding this comment.
Suggested change
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is `false`. | |
| local | Boolean | Whether to return information from the local node only instead of from the cluster manager node. Default is `false`. |
_api-reference/cat/cat-plugins.md
Outdated
| Parameter | Type | Description | ||
| :--- | :--- | :--- | ||
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is false. | ||
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is `false`. |
There was a problem hiding this comment.
Suggested change
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is `false`. | |
| local | Boolean | Whether to return information from the local node only instead of from the cluster manager node. Default is `false`. |
| Parameter | Type | Description | ||
| :--- | :--- | :--- | ||
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is false. | ||
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is `false`. |
There was a problem hiding this comment.
Suggested change
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is `false`. | |
| local | Boolean | Whether to return information from the local node only instead of from the cluster manager node. Default is `false`. |
_api-reference/cat/cat-shards.md
Outdated
| :--- | :--- | :--- | ||
| bytes | Byte size | Specify the units for byte size. For example, `7kb` or `6gb`. For more information, see [Supported units]({{site.url}}{{site.baseurl}}/opensearch/units/). | ||
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is false. | ||
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is `false`. |
There was a problem hiding this comment.
Suggested change
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is `false`. | |
| local | Boolean | Whether to return information from the local node only instead of from the cluster manager node. Default is `false`. |
| Parameter | Type | Description | ||
| :--- | :--- | :--- | ||
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is false. | ||
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is `false`. |
There was a problem hiding this comment.
Suggested change
| local | Boolean | Whether to return information from the local node only instead of from the cluster_manager node. Default is `false`. | |
| local | Boolean | Whether to return information from the local node only instead of from the cluster manager node. Default is `false`. |
| batched_reduce_size | Integer | How many shard results to reduce on a node. Default is 512. | ||
| cancel_after_time_interval | Time | The time after which the search request will be canceled. Request-level parameter takes precedence over cancel_after_time_interval [cluster setting]({{site.url}}{{site.baseurl}}/api-reference/cluster-settings). Default is -1. | ||
| ccs_minimize_roundtrips | Boolean | Whether to minimize roundtrips between a node and remote clusters. Default is true. | ||
| ccs_minimize_roundtrips | Boolean | Whether to minimize roundtrips between a node and remote clusters. Default is `true`. |
There was a problem hiding this comment.
Suggested change
| ccs_minimize_roundtrips | Boolean | Whether to minimize roundtrips between a node and remote clusters. Default is `true`. | |
| ccs_minimize_roundtrips | Boolean | Whether to minimize round trips between a node and remote clusters. Default is `true`. |
_tuning-your-cluster/availability-and-recovery/snapshots/sm-api.md
Outdated
Show resolved
Hide resolved
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
4 tasks
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
approved these changes
Jul 10, 2024
…i.md Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
* Quote all default is true/false. Signed-off-by: dblock <dblock@amazon.com> * Fixed non-boolean defaults. Signed-off-by: dblock <dblock@amazon.com> * Replaced cluster_manager node by cluster manager node. Signed-off-by: dblock <dblock@amazon.com> * Replaced master node by cluster manager node. Signed-off-by: dblock <dblock@amazon.com> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Update _tuning-your-cluster/availability-and-recovery/snapshots/sm-api.md Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> --------- Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> (cherry picked from commit a94e5b6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-documentation-website-forl
that referenced
this pull request
Jul 24, 2024
* Quote all default is true/false. Signed-off-by: dblock <dblock@amazon.com> * Fixed non-boolean defaults. Signed-off-by: dblock <dblock@amazon.com> * Replaced cluster_manager node by cluster manager node. Signed-off-by: dblock <dblock@amazon.com> * Replaced master node by cluster manager node. Signed-off-by: dblock <dblock@amazon.com> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Update _tuning-your-cluster/availability-and-recovery/snapshots/sm-api.md Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> --------- Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
sandervandegeijn
pushed a commit
to sandervandegeijn/documentation-website
that referenced
this pull request
Jul 30, 2024
* Quote all default is true/false. Signed-off-by: dblock <dblock@amazon.com> * Fixed non-boolean defaults. Signed-off-by: dblock <dblock@amazon.com> * Replaced cluster_manager node by cluster manager node. Signed-off-by: dblock <dblock@amazon.com> * Replaced master node by cluster manager node. Signed-off-by: dblock <dblock@amazon.com> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Update _tuning-your-cluster/availability-and-recovery/snapshots/sm-api.md Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> --------- Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Sander van de Geijn <sandervandegeijn@icloud.com>
bwolak
added a commit
to bwolak/documentation-website
that referenced
this pull request
Nov 20, 2024
In opensearch-project#7660 there was an effort to find-and-replace `master` with `cluster manager`. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes. I also simplified the sentence, as the "nomenclature" part is unnecessary. Signed-off-by: Benjamin Wolak <bwolak@crunchbase.com>
1 task
kolchfa-aws
pushed a commit
that referenced
this pull request
Nov 20, 2024
In #7660 there was an effort to find-and-replace `master` with `cluster manager`. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes. I also simplified the sentence, as the "nomenclature" part is unnecessary. Signed-off-by: Benjamin Wolak <bwolak@crunchbase.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
In #7660 there was an effort to find-and-replace `master` with `cluster manager`. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes. I also simplified the sentence, as the "nomenclature" part is unnecessary. Signed-off-by: Benjamin Wolak <bwolak@crunchbase.com> (cherry picked from commit 6da9e56) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
In #7660 there was an effort to find-and-replace `master` with `cluster manager`. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes. I also simplified the sentence, as the "nomenclature" part is unnecessary. Signed-off-by: Benjamin Wolak <bwolak@crunchbase.com> (cherry picked from commit 6da9e56) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
In #7660 there was an effort to find-and-replace `master` with `cluster manager`. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes. I also simplified the sentence, as the "nomenclature" part is unnecessary. Signed-off-by: Benjamin Wolak <bwolak@crunchbase.com> (cherry picked from commit 6da9e56) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
In #7660 there was an effort to find-and-replace `master` with `cluster manager`. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes. I also simplified the sentence, as the "nomenclature" part is unnecessary. Signed-off-by: Benjamin Wolak <bwolak@crunchbase.com> (cherry picked from commit 6da9e56) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
epugh
pushed a commit
to o19s/documentation-website
that referenced
this pull request
Nov 23, 2024
…-project#8784) In opensearch-project#7660 there was an effort to find-and-replace `master` with `cluster manager`. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes. I also simplified the sentence, as the "nomenclature" part is unnecessary. Signed-off-by: Benjamin Wolak <bwolak@crunchbase.com> Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
epugh
pushed a commit
to o19s/documentation-website
that referenced
this pull request
Jul 2, 2025
…-project#8784) In opensearch-project#7660 there was an effort to find-and-replace `master` with `cluster manager`. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes. I also simplified the sentence, as the "nomenclature" part is unnecessary. Signed-off-by: Benjamin Wolak <bwolak@crunchbase.com> Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bulk replaced all default is true/false and, hopefully, all other alphanumeric defaults, with quoted versions.
Version
2.x
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.