Skip to content

Conversation

@vagimeli
Copy link
Contributor

@vagimeli vagimeli commented Dec 22, 2023

Description

Closes content gap

Issues Resolved

Closes #4647

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Copy link
Contributor Author

@hdhalter We need a dev to take the first pass at drafting this content. I can support them in refining the content and getting it through the documentation process. The ingest processor template is provided with this PR, so it should help the dev get started. Thanks!

@vagimeli vagimeli added the Backlog - DOC Doc writer assigned to issue responsible for creating PR. label Jan 10, 2024
@vagimeli vagimeli marked this pull request as draft February 15, 2024 21:10
@vagimeli vagimeli marked this pull request as ready for review April 26, 2024 20:27
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli vagimeli added Tech review PR: Tech review in progress and removed Backlog - DOC Doc writer assigned to issue responsible for creating PR. Needs SME labels May 2, 2024
@vagimeli
Copy link
Contributor Author

@gaobinlong This PR is ready for your review at your availability. Thank you for all your technical reviews on these topics!

@vagimeli vagimeli added the backport 2.14 PR: Backport label for 2.14 label May 28, 2024
@vagimeli vagimeli added Editorial review PR: Editorial review in progress and removed Tech review PR: Tech review in progress labels Jun 7, 2024
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli Please see my comments and changes and let me know if you have any questions. Thanks!

vagimeli and others added 6 commits June 10, 2024 08:20
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Copy link
Contributor Author

@natebower Thank you for the thorough review. I've accepted your edits. Will you approve for merging? This is part of the series that I opened PRs and co-authored with dev, but can't approve. Thank you.

@vagimeli vagimeli removed the Editorial review PR: Editorial review in progress label Jun 10, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagimeli vagimeli merged commit 7fd934b into main Jun 10, 2024
@vagimeli vagimeli deleted the trim-processor branch June 10, 2024 15:23
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 10, 2024
* Add trim processor documentation

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Writing and editing

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Writing and editing

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update trim.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/trim.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/trim.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/trim.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/trim.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/trim.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

---------

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
(cherry picked from commit 7fd934b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RasonJ pushed a commit to o19s/documentation-website that referenced this pull request Jun 12, 2024
* Add trim processor documentation

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Writing and editing

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Writing and editing

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update trim.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/trim.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/trim.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/trim.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/trim.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/trim.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

---------

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: RasonJ <145287540+RasonJ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.14 PR: Backport label for 2.14 Content gap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[META DOC] Ingest Processors Content Gaps

4 participants