Skip to content

Conversation

@vagimeli
Copy link
Contributor

Description

Closes content gap

Issues Resolved

#4647

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Copy link
Contributor Author

@hdhalter We need a dev to take the first pass at drafting this content. I can support them in refining the content and getting it through the documentation process. The ingest processor template is provided with this PR, so it should help the dev get started. Thanks!

@vagimeli vagimeli marked this pull request as draft February 15, 2024 21:15
@vagimeli vagimeli added the backport 2.14 PR: Backport label for 2.14 label May 22, 2024
@vagimeli vagimeli marked this pull request as ready for review May 22, 2024 19:32
vagimeli added 4 commits May 22, 2024 13:32
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli vagimeli added Tech review PR: Tech review in progress and removed Needs SME labels May 29, 2024
@vagimeli
Copy link
Contributor Author

@gaobinlong This PR is ready for your technical review. Thank you!

Copy link
Contributor

@gaobinlong gaobinlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vagimeli added 3 commits June 5, 2024 10:33
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli vagimeli added Editorial review PR: Editorial review in progress and removed Tech review PR: Tech review in progress labels Jun 5, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli Please see my changes and let me know if you have any questions. Thanks!

vagimeli and others added 6 commits June 6, 2024 08:11
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Copy link
Contributor Author

vagimeli commented Jun 6, 2024

@natebower Thank you for the thorough review. I've accepted your edits. Will you approve for merging? I opened the PR instead of having the dev open it and now can't approve it. Thank you.

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagimeli vagimeli merged commit 2b61df2 into main Jun 6, 2024
@vagimeli vagimeli deleted the gsub-processor branch June 6, 2024 14:23
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 6, 2024
* Add gsub processor documentation

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Add request examples and explantory text

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Add parameters

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update gsub.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update gsub.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update gsub.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update gsub.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/gsub.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/gsub.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/gsub.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/gsub.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/gsub.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

---------

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
(cherry picked from commit 2b61df2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@vagimeli vagimeli removed the Editorial review PR: Editorial review in progress label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.14 PR: Backport label for 2.14 Content gap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants