-
Notifications
You must be signed in to change notification settings - Fork 628
Corrects the documentation for the otel_trace processor #11043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrects the documentation for the otel_trace processor #11043
Conversation
…at it adds fields. Signed-off-by: David Venable <dlv@amazon.com>
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
kolchfa-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @dlvenable!
_data-prepper/pipelines/configuration/processors/otel-traces.md
Outdated
Show resolved
Hide resolved
Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
natebower
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Corrects the documentation for the otel_trace processor to clarify that it adds fields. Signed-off-by: David Venable <dlv@amazon.com> * Update _data-prepper/pipelines/configuration/processors/otel-traces.md Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> --------- Signed-off-by: David Venable <dlv@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> (cherry picked from commit 949fe90) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
The Data Prepper
otel_traceprocessor adds fields to events. But, the documentation indicates that these are parameters. This PR corrects that.Issues Resolved
N/A
Version
Data Prepper - all versions
Frontend features
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.