Add a tabbed panel UI for showing examples in multiple languages. #10088
+305
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
kolchfa-aws
requested review from
Naarcha-AWS,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
AMoo-Miki
reviewed
Jun 19, 2025
AMoo-Miki
reviewed
Jun 19, 2025
AMoo-Miki
reviewed
Jun 19, 2025
assets/js/listener.js
Outdated
Comment on lines
45
to
51
| nav.addEventListener('scroll', (e) => { | ||
| if (nav.scrollTop > 0) { | ||
| versionPanel.classList.add('nav-shadow'); | ||
| } else { | ||
| versionPanel.classList.remove('nav-shadow'); | ||
| } | ||
| }); |
There was a problem hiding this comment.
This needs debouncing; in its current shape it could drastically impact performance.
AMoo-Miki
reviewed
Jun 19, 2025
AMoo-Miki
approved these changes
Jun 19, 2025
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Co-authored-by: Miki <miki@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
|
Thanks so much for reviewing, @AMoo-Miki! I addressed your comments. |
akshansh-modi
pushed a commit
to akshansh-modi/documentation-website
that referenced
this pull request
Jul 2, 2025
…ensearch-project#10088) * first solution Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Working tabs and copy button Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Working tabs with copy and copy as curl Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Working tabs with buttons and language specification Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Final working version Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Make vale ignore code blocks Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Update block ingores regex Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Final version with old and new style buttons working Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Make code blocks scrollable Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * No gap in buttons Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Add more languages and move buttons up Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Add all supported languages and formatting guide entry Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Clean up comments Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Remove tabbed panel testing Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Code review feedback Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Update assets/js/listener.js Co-authored-by: Miki <miki@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> * Simplify if logic Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> --------- Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Miki <miki@amazon.com> Signed-off-by: apple <akshanshmodi2002@gmail.com>
epugh
pushed a commit
to o19s/documentation-website
that referenced
this pull request
Jul 2, 2025
…ensearch-project#10088) * first solution Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Working tabs and copy button Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Working tabs with copy and copy as curl Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Working tabs with buttons and language specification Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Final working version Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Make vale ignore code blocks Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Update block ingores regex Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Final version with old and new style buttons working Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Make code blocks scrollable Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * No gap in buttons Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Add more languages and move buttons up Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Add all supported languages and formatting guide entry Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Clean up comments Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Remove tabbed panel testing Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Code review feedback Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Update assets/js/listener.js Co-authored-by: Miki <miki@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> * Simplify if logic Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> --------- Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Miki <miki@amazon.com> Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1926 Add a tabbed panel UI for showing examples in multiple languages.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.