Skip to content

Conversation

@vecheka
Copy link
Contributor

@vecheka vecheka commented Nov 3, 2025

Description

Move MetricsHelper to common utils class instead so it can be used by other connectors.

Testing

Ran the following successfully:

./gradlew :data-prepper-plugins:saas-source-plugins:microsoft-office365-source:test \
--tests "org.opensearch.dataprepper.plugins.source.microsoft_office365.Office365CrawlerClientTest"

./gradlew :data-prepper-plugins:saas-source-plugins:microsoft-office365-source:test \
--tests "org.opensearch.dataprepper.plugins.source.microsoft_office365.Office365RestClientTest"


./gradlew :data-prepper-plugins:saas-source-plugins:microsoft-office365-source:checkstyleTest  

Issues Resolved

N/A

Check List

  • [ x ] New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vecheka Chhourn <vecheka@amazon.com>
@vecheka vecheka force-pushed the fix/move-metric-helper-to-utils branch from 328bf72 to 9e129c1 Compare November 3, 2025 19:33
@san81 san81 merged commit 8cb0051 into opensearch-project:main Nov 3, 2025
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants