Skip to content

Conversation

@dlvenable
Copy link
Member

@dlvenable dlvenable commented Oct 21, 2025

Description

Adds integration tests for the DynamoDbSourceCoordinationStore that use an embedded DynamoDB database to test.

To support better testing and cleaner code, this also updates the plugin to use Spring dependency injection that Data Prepper now offers to plugin authors.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…se an embedded DynamoDB database to test.

To support better testing and cleaner code, this also updates the plugin to use the Spring DI capabilities that Data Prepper now offers to plugin authors.

Signed-off-by: David Venable <dlv@amazon.com>
@dlvenable dlvenable force-pushed the source-coordination-ddb-testing branch from c2efee6 to 636c0de Compare November 1, 2025 19:14
…ordination store project because it creates an ANTLR conflict with DynamoDBLocal.

Signed-off-by: David Venable <dlv@amazon.com>
Copy link
Member

@graytaylor0 graytaylor0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these integration tests!

Copy link
Collaborator

@san81 san81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see all those static keywords removed 👍

@dlvenable
Copy link
Member Author

Nice to see all those static keywords removed 👍

That's thanks to your work on supporting DI in plugins!

@dlvenable dlvenable merged commit 9749c8e into opensearch-project:main Nov 3, 2025
47 checks passed
@dlvenable dlvenable deleted the source-coordination-ddb-testing branch November 4, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants