MAINT: use tmp folder for default db path for service-map #5037
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Chen <qchea@amazon.com>
chenqi0805
requested review from
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dlvenable
requested changes
Oct 9, 2024
| @@ -16,7 +16,7 @@ | |||
| public class ServiceMapProcessorConfig { | |||
| private static final String WINDOW_DURATION = "window_duration"; | |||
| static final int DEFAULT_WINDOW_DURATION = 180; | |||
| static final String DEFAULT_DB_PATH = "data/service-map/"; | |||
| static final String DEFAULT_DB_PATH = "/tmp/data/service-map/"; | |||
There was a problem hiding this comment.
I don't think this is the right solution. In fact, we've had issues in the past where Data Prepper is trying to write to directories it does not have access to such as /tmp.
Maybe, make this configurable instead?
There was a problem hiding this comment.
Thanks for suggestion! made the change
Signed-off-by: George Chen <qchea@amazon.com>
Signed-off-by: George Chen <qchea@amazon.com>
graytaylor0
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change default DB path for service map to be under /tmp since it is only used for off-heap memory
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.