Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and improvements for AbstractSinkTest #5021

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes and improvements for AbstractSinkTest #5021

wants to merge 2 commits into from

Commits on Oct 4, 2024

  1. Fixes and improvements for AbstractSinkTest 

    Reworked the tests to be somewhat faster. Reworked one flaky test such that it appears to be passing consistently now by using finer-grained control on the timing. Finished one test by making it actually verify the metrics, which is what it was apparently intended to do in the first place.

Signed-off-by: David Venable <dlv@amazon.com>
    @dlvenable
    dlvenable committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c8b1918 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Be more lenient on the retry thread state. It may be in the sleep() w… 

    …hich is ok for the purpose of this test.

Signed-off-by: David Venable <dlv@amazon.com>
    @dlvenable
    dlvenable committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    aebaf37 View commit details
    Browse the repository at this point in the history