Add bucket owner support to s3 sink #4504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
asifsmohammed,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
graytaylor0
force-pushed
the
BucketOwnerS3Sink
branch
2 times, most recently
from
842e130
to
b1c283a
Compare
dinujoh
reviewed
May 8, 2024
| return roleArn.accountId().get(); | ||
| } | ||
|
|
||
| return null; |
There was a problem hiding this comment.
when will this be null ? Looks like StaticBucketOwnerProvider will throw NPE when account is null. Is this user error in the role ?
There was a problem hiding this comment.
Yeah. I can just change it to throw exception
Signed-off-by: Taylor Gray <tylgry@amazon.com>
Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
force-pushed
the
BucketOwnerS3Sink
branch
from
b1c283a
to
181daad
Compare
dinujoh
approved these changes
May 8, 2024
kkondaka
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to the S3 source, the S3 sink now has
default_bucket_ownerandbucket_ownersmap to be passed to theexpectedBucketOwnerof the S3 sink requests. This is to prevent sending to this bucket if the owner of the bucket changes.Issues Resolved
Resolves #4468
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.