Add 'typeof' operator to DataPrepper expressions #4500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
added 4 commits
May 4, 2024 18:02
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
graytaylor0
previously approved these changes
May 6, 2024
kkondaka
requested review from
chenqi0805,
engechas,
dinujoh,
asifsmohammed,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dinujoh
reviewed
May 6, 2024
data-prepper-api/src/main/java/org/opensearch/dataprepper/model/event/DataType.java
Outdated
Show resolved
Hide resolved
dinujoh
reviewed
May 6, 2024
data-prepper-api/src/main/java/org/opensearch/dataprepper/model/event/DataType.java
Show resolved
Hide resolved
dinujoh
reviewed
May 6, 2024
| DataType type = fromTypeName(option); | ||
| if (type == null) | ||
| throw new IllegalArgumentException("Unknown DataType"); | ||
| switch (type) { |
There was a problem hiding this comment.
we should add a case condition for Float & BigDecimal.
There was a problem hiding this comment.
After discussion, decided not to support these two for now as double handles float and all BigDecimals are actually strings.
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
dinujoh
reviewed
May 6, 2024
|
|
||
| @Test | ||
| void test_isSameType() { |
There was a problem hiding this comment.
Consider adding parameterized test to cover all cases.
dinujoh
reviewed
May 6, 2024
| } | ||
|
|
||
| @Test | ||
| void testEvalValidArgs() { |
There was a problem hiding this comment.
this can be parameterized test as well.
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
dinujoh
approved these changes
May 6, 2024
graytaylor0
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.