Add support for spilt event processor #4166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: srigovs <srigovs@amazon.com>
srikanthjg
requested review from
asifsmohammed,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka and
oeyh
as code owners
dlvenable
requested changes
Feb 21, 2024
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| plugins { |
There was a problem hiding this comment.
You don't need this block. It is already applied.
| implementation 'com.fasterxml.jackson.core:jackson-databind' | ||
| } | ||
|
|
||
| test { |
There was a problem hiding this comment.
You don't need this block. It is already applied.
|
|
||
| // when no splits or empty value modify the original event | ||
| if(splitValues.length <= 1) { | ||
| Record newRecord = new Record<>(recordEvent); |
There was a problem hiding this comment.
I don't think we need a new Record. Just re-use the existing one.
|
|
||
| // Modify original event to hold the last split | ||
| recordEvent.put(field, splitValues[splitValues.length-1]); | ||
| Record newRecord = new Record<>(recordEvent); |
There was a problem hiding this comment.
You can re-use the existing Record here as well.
| final Object value = recordEvent.get(field, Object.class); | ||
|
|
||
| //split record according to delimiter | ||
| final String[] splitValues = pattern.split((String) value); |
There was a problem hiding this comment.
Rather than create a Pattern for both regex and delimiter, I think you could make a Function. Then you can avoid a regex.
private final Function<String, String[]> splitter;
...
@DataPrepperPluginConstructor
public SplitEventProcessor(final PluginMetrics pluginMetrics, final SplitEventProcessorConfig config) {
...
if(delimiterRegex != null && !delimiterRegex.isEmpty()) {
Pattern pattern = Pattern.compile(delimiterRegex);
splitter = inputString -> pattern.split(inputString);
} else {
splitter = inputString -> inputString.split(delimiter);
}
}
Then this line becomes:
final String[] splitValues = splitter.apply((String) value);
Signed-off-by: srigovs <srigovs@amazon.com>
Signed-off-by: srigovs <srigovs@amazon.com>
Signed-off-by: srigovs <srigovs@amazon.com>
dlvenable
previously approved these changes
Feb 21, 2024
| final String delimiter; | ||
| final String delimiterRegex; | ||
| final String field; | ||
| final Pattern pattern; |
There was a problem hiding this comment.
I don't think you need to retain this as a field. The lambda will hold a reference to the Pattern.
kkondaka
previously approved these changes
Feb 26, 2024
|
@srikanthjg please resolve the conflicts, then we can merge the PR |
Signed-off-by: Srikanth Govindarajan <srikanthjg123@gmail.com>
kkondaka
approved these changes
Feb 28, 2024
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds split event processor as described in #4089
Issues Resolved
Resolves #4089
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.